summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2024-04-03store: database: Rename a couple of procedures.Christopher Baines
These names should be more descriptive. * guix/store/database.scm (path-id): Rename to select-valid-path-id. (sqlite-register): Rename to register-valid-path. (register-items): Update accordingly. Change-Id: I6d4a14d4cde9d71ab34d6ffdbfbfde51b2c0e1db
2024-04-03store: database: Refactor sqlite-register.Christopher Baines
The update-or-insert procedure name was unhelpfully generic, and these changes should improve the code readability. * guix/store/database.scm (update-or-insert): Remove procedure and inline functionality in to sqlite-register. Change-Id: Ifab0cdb7972d095460cc1f79b8b2f0e9b958059c
2024-04-03store: database: Stop finalizing prepared statements.Christopher Baines
Especially since we're asking for these to be cached. Management of prepared statements isn't trivial, since you don't want to keep them forever as this can lead to poor query performance, but I don't think that finalizing them immediately is the right solution. Change-Id: I61706b4d09d771835bb8f074b8f6a6ee871f5e2d * guix/store/database.scm (sqlite-step-and-reset): New procedure. (last-insert-row, path-id, update-or-insert, add-references): Don't finalize prepared statements. Change-Id: I2a2c6deb43935d67df9e43000a5105343d72b3e6
2024-04-03store: database: Inline SQL to where it's used.Christopher Baines
This makes the code easier to read, as you don't have to keep jumping between the two places. * guix/store/database.scm (path-id-sql, update-sql, insert-sql, add-reference-sql): Remove variables. (path-id, update-or-insert, add-references): Include SQL. Change-Id: I53b4ab973be8d0cd10a0f35ba25972f1c9680353
2024-04-03store: database: Remove with-statement and associated code.Christopher Baines
I think using dynamic-wind to finalize all statements is the wrong approach. Firstly it would be good to allow reseting statements rather than finalizing them. Then for the problem of handling errors, the approach I've settled on in the build coordinator is to close the database connection, since that'll trigger guile-sqlite3 to finalize all the cached statements. This reverts commit 5d6e2255286e591def122ec2f4a3cbda497fea21. * .dir-locals.el (scheme-mode): Remove with-statement. * guix/store/database.scm (call-with-statement): Remove procedure. (with-statement): Remove syntax rule. (call-with-transaction, last-insert-row-id, path-id, update-or-insert, add-references): Don't use with-statement. Change-Id: I2fd976b3f12ec8105cc56350933a953cf53647e8
2024-04-03store: database: Remove call-with-savepoint and associated code.Christopher Baines
While care does need to be taken with making updates or inserts to the ValidPaths table, I think that trying to ensure this within update-or-insert is the wrong approach. Instead, when working with the store database, only one connection should be used to make changes to the database and those changes should happen in transactions that ideally begin immediately. This reverts commit 37545de4a3bf59611c184b31506fe9a16abe4c8b. * .dir-locals.el (scheme-mode): Remove entries for call-with-savepoint and call-with-retrying-savepoint. * guix/store/database.scm (call-with-savepoint, call-with-retrying-savepoint): Remove procedures. (update-or-insert): Remove use of call-with-savepoint. Change-Id: I2f986e8623d8235a90c40d5f219c1292c1ab157b
2024-04-03scripts: substitute: Replace some leave calls with raise.Christopher Baines
These calls happen inside of with-error-handling, so the effect should be the same, but this opens up the possibility of using this code in a program that doesn't want to exit when one of these error conditions is met. Change-Id: I15d963615d85d419559fa0f4333fa4dc1dfbfd3b * guix/scripts/substitute.scm (download-nar, process-substitution): Use raise formatted-message rather than leave. Change-Id: Idd0880206b69e3903e19e0536b87d65a52c200d5
2024-04-03scripts: substitute: Allow not using with-timeout in download-nar.Christopher Baines
I don't think the approach of using SIGALARM here for the timeout will work well in all cases (e.g. when using Guile Fibers), so make it possible to avoid this. * guix/scripts/substitute.scm (download-nar): Pass the fetch timeout in as an option. Change-Id: I8cbe6cdfa10cdaa7d41974cbea56a95f5efecfe6
2024-04-03scripts: substitute: Remove side effect warning from network-error?.Christopher Baines
Instead, display the warning from process-substitution and process-substitution/fallback in the relevant places. I'm looking at this because I want to make the substitute code less tied to the script and usable in the Guile guix-daemon. * guix/scripts/substitute.scm (network-error?): Move warning to… (process-substitution/fallback, process-substitution): here. Change-Id: I082b482c0e6ec7e02a8d437ba22dcefca5c40787
2024-04-03Switch order of the default substitute servers.Christopher Baines
The aim here is to improve the user experience. There's anecdotal evidence that the network performance for bordeaux is better compared to ci at least for some users, and I don't know of any issues with rate limiting or access restriction for bordeaux compared to ci. It also has IPv6 support. Additionally, bordeaux generally had more substitutes than ci, particularly for aarch64-linux and armhf-linux. This change will offer a very slight speedup for those substitutes that only bordeaux has. Bordeaux has been a default substitute server for nearly 3 years now and I think this change is overdue. I'm also hopeful that we'll be able to build on the testing regarding mirrors for bordeaux, and that'll allow potentially improving the hosting setup (through providing more redundancy) and further improving substitute fetching for users who currently have issues with substitute access. * config-daemon.ac: Switch substitute urls order. * doc/guix.texi: Ditto. * etc/guix-install.sh: Ditto. * gnu/installer/newt/network.scm (wait-service-online): Ditto. * guix/store.scm (%default-substitute-urls): Ditto. Change-Id: I4f6d93ae1fc8b03d80b47b18b5749a51f1fde17b Signed-off-by: Christopher Baines <mail@cbaines.net>
2024-04-03gnu: sonata: Add gvfs as an input.Christopher Baines
I'm getting the following error and this change resolves it: /gnu/store/rw6n86c008xqdbjs3nk4i7ggf6srdpgs-python-wrapper-3.10.7/bin/python: symbol lookup error: /run/current-system/profile/lib/gio/modules/libgvfsdbus.so: undefined symbol: g_task_set_static_name Change-Id: I6f74a5a867ba7c3b3d7b233916af0e75d9e5501f Signed-off-by: Christopher Baines <mail@cbaines.net>
2024-04-03maint: Fix help2man for guix subcommands with `make V=2'.Janneke Nieuwenhuizen
* doc/local.mk ($(srcdir)/%D%/guix-%.1): Use AM_V_HELP2MAN and cater for make's `@' silencing at the start of the command. Change-Id: Id80c48f0d7697167fea64700a7fe140003732d28
2024-04-03gnu: emacs-magit: Fix generation of autoloads.Liliana Marie Prikler
* gnu/packages/emacs-xyz.scm (emacs-magit)[#:phases]: Replace ‘make-autoloads’ like the others. Fixes: Magit autoloads are missing <https://bugs.gnu.org/70121> Change-Id: Iec1d89b167211889743ed1e7e64a9f866ea4c2eb Signed-off-by: Clément Lassieur <clement@lassieur.org>
2024-04-02gnu: qt-creator: Fix patch-perfparser phase.Maxim Cournoyer
This is a follow-up to f83bdd7e00 ("gnu: qt-creator: Patch file names of demangling libraries.") * gnu/packages/qt.scm (qt-creator) [phases] <patch-perfparser>: Adjust demangler.cpp file name. Change-Id: I72c517636bf866b57daa5d56dd8db643b0669a88
2024-04-02gnu: Add hotspot.Maxim Cournoyer
* gnu/packages/linux.scm (hotspot): New variable. Change-Id: Id6a0baae459bccf78c80d17f884f3fa7344ff1ac
2024-04-02gnu: Add kddockwidgets-1.Maxim Cournoyer
* gnu/packages/qt.scm (kddockwidgets-1): New variable. Change-Id: Id766646155e02d412ea87932a79aae95a943ff9b
2024-04-02gnu: Add kddockwidgets.Maxim Cournoyer
* gnu/packages/qt.scm (kddockwidgets): New variable. Change-Id: I0598b16da4f027f9c42584f30a49fcbba2f5a78e
2024-04-02gnu: qt-creator: Patch file names of demangling libraries.Maxim Cournoyer
* gnu/packages/qt.scm (qt-creator) [phases] {patch-perfparser}: New phase. Change-Id: I65f84158af05ae866680b21e2e9b8e24a2b71bc2
2024-04-02gnu: cqfd: Update to 5.5.0.Maxim Cournoyer
* gnu/packages/docker.scm (cqfd): Update to 5.5.0. Change-Id: Ib8ba9ee06744869efc1489beb4e2d56fe0cc06e0
2024-04-02maint: Add perl to the manifest.Janneke Nieuwenhuizen
* manifest.scm: Add perl. Change-Id: Ie70cea1eb4d62f2a649292209391a92abdae2288
2024-04-02gnu: gpaste: Update to 44.1.Attila Lendvai
* gnu/packages/gnome-xyz.scm (gpaste): Update to 44.1. [native-inputs]: Replace GCR-3 with GCR. [inputs]: Replace GTK with GTK+. Add DESKTOP-FILE-UTILS. Remove LIBARCHIVE. Signed-off-by: Leo Famulari <leo@famulari.name> Change-Id: I9e9548a9e3393dfa4b9e7b64978418106fb25db1
2024-04-02gnu: clojure-tools: Update to 1.11.1.1413.Eugen Stan
* gnu/packages/clojure.scm (clojure-tools): Update to 1.11.1.1413. [inputs]: Add clojure-tools-deps. Remove clojure-tools-deps-alpha. Signed-off-by: Efraim Flashner <efraim@flashner.co.il> Change-Id: I52fda6af441d1cd2ba271153f87eb0c35bce31cb
2024-04-02gnu: Add clojure-tools-deps.Eugen Stan
* gnu/packages/crates-io.scm (clojure-tools-deps): New variable. Signed-off-by: Efraim Flashner <efraim@flashner.co.il> Change-Id: Ic02349bfe5b899874ff8e6067e790ca9d9f1f96e
2024-04-02gnu: icewm: Update to 3.4.7.Andy Tai
* gnu/packages/wm.scm (icewm): Update to 3.4.7. Change-Id: I6daa66be92a01ae587efec2bf3f0ac4769ae797a Signed-off-by: Efraim Flashner <efraim@flashner.co.il>
2024-04-02gnu: clifm: Update to 1.18.Rodion Goritskov
* gnu/packages/clifm.scm (clifm): Update to 1.18. Change-Id: Ic0c2a307dbbcca06cfffe60248234849dca2f726 Signed-off-by: Efraim Flashner <efraim@flashner.co.il>
2024-04-02gnu: gtk: Fix tests on aarch64.Leo Nikkilä
* gnu/packages/gtk.scm (gtk)[arguments]<#:configure-flags>: Skip more failing tests known to fail. Signed-off-by: Efraim Flashner <efraim@flashner.co.il> Change-Id: I34d0f7521224b41072fcc0c35321935d1db927e0
2024-04-02Revert "gnu: gtk: Skip failing tests on aarch64-linux."Efraim Flashner
This reverts commit 76ed1e886ea790fc8562b355a0768a0f04889abb. The next commit does a better job of skipping the tests.
2024-04-02gnu: parallel: Update to 20240322.Andy Tai
* gnu/packages/parallel.scm (parallel): Update to 20240322. Change-Id: I7207d4847cd407de637334688242132e8c557490 Signed-off-by: Efraim Flashner <efraim@flashner.co.il>
2024-04-02gnu: pinentry-rofi: Update to 2.1.0.Fredrik Salomonsson
* gnu/packages/gnupg.scm (pinentry-rofi): Update to 2.1.0. Change-Id: Ie39dfadc9905032e2a6cd08858596b7fdfd5c6dd Signed-off-by: Efraim Flashner <efraim@flashner.co.il>
2024-04-02gnu: debootstrap: Use pureos-archive-keyring.Denis 'GNUtoo' Carikli
* gnu/packages/debian.scm (debootstrap): [arguments]: In 'patch-source' phase, use pureos-archive-keyring. [inputs]: Add pureos-archive-keyring. Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> Change-Id: I8bf0a7db50c66dcf3541e5c7244350ff9523d921 Signed-off-by: Efraim Flashner <efraim@flashner.co.il>
2024-04-02gnu: Add pureos-archive-keyring.Denis 'GNUtoo' Carikli
* gnu/packages/debian.scm (pureos-archive-keyring): New variable. Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> Change-Id: I80af4b15c7fe20dd40358d4f676a89903060bf07 Signed-off-by: Efraim Flashner <efraim@flashner.co.il>
2024-04-02gnu: greetd: Fix cross-compilation.dan
* gnu/packages/admin.scm (greetd): Fix cross-compilation. [native-inputs]: Move linux-pam from here ... [inputs]: ... to here. [arguments]<#:phases>: Set release directory based on target. Change-Id: I822f8f215677bc951b21e46dddf44954a43df58f Signed-off-by: Efraim Flashner <efraim@flashner.co.il>
2024-04-02gnu: ngtcp2: Update to 1.4.0.Tomas Volf
* gnu/packages/networking.scm (ngtcp2): Update to 1.4.0. Change-Id: I87a91913dd12affe18d240235c39a5639c798801 Signed-off-by: Efraim Flashner <efraim@flashner.co.il>
2024-04-02gnu: ccid: Fix cross-compilation.dan
* gnu/packages/security-token.scm (ccid): Fix cross-compilation. Change-Id: I15c96a57e155742f5a2a8394402ae0fb0563f663 Signed-off-by: Efraim Flashner <efraim@flashner.co.il>
2024-04-02gnu: libjxl: Fix build on riscv64-linux.Zheng Junjie
* gnu/packages/image.scm (libjxl) [arguments]: Add fix-atomic phase when target riscv64-linux. Change-Id: I442c668c3d52c241f0d405f51ea8d995bfefd3fd Signed-off-by: Efraim Flashner <efraim@flashner.co.il>
2024-04-02gnu: ruby-stackprof: Remove store file name.Janneke Nieuwenhuizen
This is a follow-up to commit d7e092719a4e0e168df56c03076a87c0e32692e5|head gnu: ruby-stackprof: Skip test known to fail. * gnu/packages/ruby.scm (ruby-stackprof): Remove literal store file name from comment. This fixes `make dist'. Change-Id: Ifc71c9f664790a27a0ed7f3dacd2189dbc1f6ba6
2024-04-02gnu: r-tcgabiolinks: Update to 2.30.4.Ricardo Wurmus
* gnu/packages/bioconductor.scm (r-tcgabiolinks): Update to 2.30.4. Change-Id: Ib0f5a7f9855c21b378060b7a9e1af031effda624
2024-04-02gnu: r-bionero: Update to 1.10.3.Ricardo Wurmus
* gnu/packages/bioconductor.scm (r-bionero): Update to 1.10.3. Change-Id: I03b6f9259c05a6915d3e5425ab9165067c400f03
2024-04-02gnu: r-catalyst: Update to 1.26.1.Ricardo Wurmus
* gnu/packages/bioconductor.scm (r-catalyst): Update to 1.26.1. Change-Id: I32cff6ff74a76770212ab24a08805baf00bb7adc
2024-04-02gnu: r-biocfilecache: Update to 2.10.2.Ricardo Wurmus
* gnu/packages/bioconductor.scm (r-biocfilecache): Update to 2.10.2. Change-Id: I23fdcff4ba85610aeee21504ff9313c6163d46bd
2024-04-02gnu: r-seqarray: Update to 1.42.3.Ricardo Wurmus
* gnu/packages/bioconductor.scm (r-seqarray): Update to 1.42.3. Change-Id: I8fedfd9709519ad2b1533840747402a56a4af2b5
2024-04-02gnu: r-lme4: Update to 1.1-35.2.Ricardo Wurmus
* gnu/packages/statistics.scm (r-lme4): Update to 1.1-35.2. Change-Id: Iadd5c9d4a3903360e4e61920da3b2c5b83be882f
2024-04-02gnu: r-rsqlite: Update to 2.3.6.Ricardo Wurmus
* gnu/packages/statistics.scm (r-rsqlite): Update to 2.3.6. Change-Id: Ib0404ffaceb949d7665aa22fc40c49c95cf3dd2c
2024-04-02gnu: r-data-table: Update to 1.15.4.Ricardo Wurmus
* gnu/packages/statistics.scm (r-data-table): Update to 1.15.4. Change-Id: Ia36df7314f9b85b5bac32f2c6dc661460f8aa5ec
2024-04-02gnu: r-munsell: Update to 0.5.1.Ricardo Wurmus
* gnu/packages/statistics.scm (r-munsell): Update to 0.5.1. Change-Id: I526337679f81d865f81b8b603305bf5f7b611539
2024-04-02gnu: r-codetools: Update to 0.2-20.Ricardo Wurmus
* gnu/packages/statistics.scm (r-codetools): Update to 0.2-20. Change-Id: I81f61bfa1a5db3f0c6e9738735cc47536e5968ae
2024-04-02gnu: r-textshape: Update to 1.7.5.Ricardo Wurmus
* gnu/packages/cran.scm (r-textshape): Update to 1.7.5. Change-Id: I070fd0e29ae4498515696ba11968684618783e62
2024-04-02gnu: r-metafor: Update to 4.6-0.Ricardo Wurmus
* gnu/packages/cran.scm (r-metafor): Update to 4.6-0. Change-Id: Idac90e66df71c8d316885966012a731d72310722
2024-04-02gnu: r-iml: Update to 0.11.2.Ricardo Wurmus
* gnu/packages/cran.scm (r-iml): Update to 0.11.2. [propagated-inputs]: Remove r-prediction. Change-Id: I9641fb9ab9e8093c9e1ece679b26799d833c158b
2024-04-02gnu: r-eulerr: Update to 7.0.2.Ricardo Wurmus
* gnu/packages/cran.scm (r-eulerr): Update to 7.0.2. Change-Id: I2cba2668de9efbbe279dd7ee89d36aab6631d7ec