summaryrefslogtreecommitdiff
path: root/guix/scripts
diff options
context:
space:
mode:
authorArun Isaac <arunisaac@systemreboot.net>2019-01-07 23:11:58 +0530
committerArun Isaac <arunisaac@systemreboot.net>2019-01-10 15:39:35 +0530
commit40fa21c22e1d11b741515fd38f5204a5fa57fbaa (patch)
tree4467c710160509287c73d40fc40e646b52d9278b /guix/scripts
parent394207c1ee05c4bb148896852f5dd90cdbff4bb5 (diff)
guix: lint: Warn only if GitHub URI is not same as the package URI.
* guix/scripts/lint.scm (check-github-url): Warn only if the GitHub URI obtained after following redirects is not same as the original URI. * tests/lint.scm ("github-url: already the correct github url"): New test.
Diffstat (limited to 'guix/scripts')
-rw-r--r--guix/scripts/lint.scm11
1 files changed, 6 insertions, 5 deletions
diff --git a/guix/scripts/lint.scm b/guix/scripts/lint.scm
index 9acec48577..0f315a9352 100644
--- a/guix/scripts/lint.scm
+++ b/guix/scripts/lint.scm
@@ -8,7 +8,7 @@
;;; Copyright © 2017 Alex Kost <alezost@gmail.com>
;;; Copyright © 2017 Tobias Geerinckx-Rice <me@tobias.gr>
;;; Copyright © 2017, 2018 Efraim Flashner <efraim@flashner.co.il>
-;;; Copyright © 2018 Arun Isaac <arunisaac@systemreboot.net>
+;;; Copyright © 2018, 2019 Arun Isaac <arunisaac@systemreboot.net>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -820,10 +820,11 @@ descriptions maintained upstream."
(lambda (uri)
(and=> (follow-redirects-to-github uri)
(lambda (github-uri)
- (emit-warning
- package
- (format #f (G_ "URL should be '~a'") github-uri)
- 'source))))
+ (unless (string=? github-uri uri)
+ (emit-warning
+ package
+ (format #f (G_ "URL should be '~a'") github-uri)
+ 'source)))))
(origin-uris origin)))))
(define (check-derivation package)