diff options
| author | Eric Bavier <bavier@posteo.net> | 2023-04-20 00:11:27 -0500 |
|---|---|---|
| committer | Ludovic Courtès <ludo@gnu.org> | 2023-04-21 16:16:38 +0200 |
| commit | 37dd69b44511dc73eb04bdebe8d82c9a0386338e (patch) | |
| tree | d20ecc2b15659ed2345f00beb39170a5365a7051 /tests/guix-gc.sh | |
| parent | a09c7da8f8d8e732f969cf0a09aaa78f87032ab1 (diff) | |
tests: Fix checks for expected failures.
Addresses <https://issues.guix.gnu.org/62406>.
With 'set -e', a return status inverted with '!' does not cause the shell to
exit immediately. Instead use '&& false' to indicate an expected failure.
* tests/guix-archive.sh, tests/guix-build-branch.sh, tests/guix-build.sh,
tests/guix-daemon.sh, tests/guix-download.sh,
tests/guix-environment-container.sh, tests/guix-environment.sh,
tests/guix-gc.sh, tests/guix-git-authenticate.sh, tests/guix-graph.sh,
tests/guix-hash.sh, tests/guix-home.sh, tests/guix-pack-relocatable.sh,
tests/guix-pack.sh, tests/guix-package-aliases.sh, tests/guix-package-net.sh,
tests/guix-package.sh, tests/guix-refresh.sh, tests/guix-shell.sh,
tests/guix-style.sh, tests/guix-system.sh: Replace uses of '! ...' with
'... && false' or `test ! ...` as appropriate.
Signed-off-by: Ludovic Courtès <ludo@gnu.org>
Diffstat (limited to 'tests/guix-gc.sh')
| -rw-r--r-- | tests/guix-gc.sh | 18 |
1 files changed, 9 insertions, 9 deletions
diff --git a/tests/guix-gc.sh b/tests/guix-gc.sh index f40619876d..675a13115d 100644 --- a/tests/guix-gc.sh +++ b/tests/guix-gc.sh @@ -36,11 +36,11 @@ unset out # For some operations, passing extra arguments is an error. for option in "" "-C 500M" "--verify" "--optimize" "--list-roots" do - ! guix gc $option whatever + guix gc $option whatever && false done # This should fail. -! guix gc --verify=foo +guix gc --verify=foo && false # Check the references of a .drv. drv="`guix build guile-bootstrap -d`" @@ -51,7 +51,7 @@ guix gc --references "$drv" | grep -e -bash guix gc --references "$out" guix gc --references "$out/bin/guile" -! guix gc --references /dev/null; +guix gc --references /dev/null && false # Check derivers. guix gc --derivers "$out" | grep "$drv" @@ -62,7 +62,7 @@ test -f "$drv" guix gc --list-dead | grep "$drv" guix gc --delete "$drv" -! test -f "$drv" +test ! -f "$drv" # Add a .drv, register it as a root. drv="`guix build --root=guix-gc-root lsh -d`" @@ -71,18 +71,18 @@ test -f "$drv" && test -L guix-gc-root guix gc --list-roots | grep "$PWD/guix-gc-root" guix gc --list-live | grep "$drv" -! guix gc --delete "$drv"; +guix gc --delete "$drv" && false rm guix-gc-root guix gc --list-dead | grep "$drv" guix gc --delete "$drv" -! test -f "$drv" +test ! -f "$drv" # Try a random collection. guix gc -C 1KiB # Check trivial error cases. -! guix gc --delete /dev/null; +guix gc --delete /dev/null && false # Bug #19757 out="`guix build guile-bootstrap`" @@ -90,14 +90,14 @@ test -d "$out" guix gc --delete "$out" -! test -d "$out" +test ! -d "$out" out="`guix build guile-bootstrap`" test -d "$out" guix gc --delete "$out/" -! test -d "$out" +test ! -d "$out" out="`guix build guile-bootstrap`" test -d "$out" |